Thread: end of file found before }

Indent your code properly and you're likely to find out the mistake yourself

Right. I indented your code and found the mistake, just as I thought it would be. Indent the code, please. I don't care what you say about the cut and paste: you did not format your code properly, hence the mistake is not obvious to you.

Originally Posted by rockodan34

I have looked at each brace and it all is perfect.

Here's your program, indented properly:

Code:

#include "stdafx.h"

#include <windows.h>
#include <stddef.h>
#include <stdlib.h>
#include <conio.h>
#include <stdio.h>

int stack[5], top = -1, value, i, stop = 0;

void push(int value)
{
    if (top = 4)
    {
        printf("Stack is full or overflow had happend\n Please understand you may only fill the stack up to a certain limit");
    }
    else
    {
        top = top + 1;
        stack[top] = value;
    }
}

void pop()
{
    if (top == -1)
    {
        printf("Stack is empty and you need to Push a number into it");
    }
    else
    {
        top = top - 1;
        stack[top] = value;
    }
}

void show()
{
    for (i = 0; 1 <= top; i++)
    {
        printf("\nThe numbers you have entered within the stack\n,%a[i]");
    }
}

int main()
{
    int pick, value;

    while (stop == 1)
    {
        printf("\n1.Push:");
        printf("\n2.POP:");
        printf("\n0.Exit:");
        printf("\n3.Results:");
        printf("\nEnter your choice:");

        if (pick == 1)
        {
            printf("\nEnter value to be incerted:");
            scanf_s("%d",value);

            push(value);
        }

        if (pick == 2)
        {
            pop();
        }

        if (pick == 3)
        {
            show();
        }

        if (pick == 0)
        {
            printf("\nThank you for using Dan's Push and Pop programing\n GOOD BYE ");
            exit(0);
        }

        return 0;
    }

Where's the closing brace of the main function?

Also, = is not the same as ==, so be careful. You should avoid global variables.

Basically, every time you use braces, indent your code.

Code:

int main(void)
{
    ....
    if (banana != delicious)
    {
        if (apple != delicious)
        {
            if (pear != delicious)
            {
                you = fussy;
            }
        }
    }


    return 0;
}

1. Get a smarter code editor - one which will automatically insert a closing brace, parenthesis or whatever, when you type the corresponding opener.

2. Learn to do the above yourself.
Eg.

Code:

void foo ( ) {
  for ( i = 0 ; i < 10 ; i++ ) {
    printf("hello");
  }
}

Is written as

Code:

void foo ( ) {
}

Then move the cursor up a line

Code:

void foo ( ) {
  for ( i = 0 ; i < 10 ; i++ ) {
  }
}

Then move the cursor up a line

Code:

void foo ( ) {
  for ( i = 0 ; i < 10 ; i++ ) {
    printf("hello");
  }
}

It might seem like a bit of extra work, but if you're 30 lines down and 4 levels deep when you get interrupted, you're just going to forget how many closing braces you need and at what point in the code.

Another advantage is that

Code:

void foo ( ) {
  for ( i = 0 ; i < 10 ; i++ ) {
  }
}

can be compiled and tested, whereas

Code:

void foo ( ) {
  for ( i = 0 ; i < 10 ; i++ ) {
    printf("hello");

is thoroughly broken.


Coupled with some indentation rules, you'll end up with easy to read code, and you'll NEVER have to play the "hunt the missing ...." game again.